Table of Contents
#206 — very section of Settings → business now fails on save, so the business name, currency, brand colours, tax and timezone can no lo (Resolved)
← Back to bug list · View issue #206 in MantisBT
Reported by: Nour aboulhosn on 2026-08-11T10:05:32+01:00
Assigned to: Claude
Resolved by: Claude on 2026-08-11T10:39:59+01:00
Severity: major
Priority: high
Reproducibility: have not tried
Category: General
Description: `POST /settings/company` returns HTTP 500 for all four of its sections — `tax`, `timezone`, `company` and `brand` — and nothing is saved. It fails even when the form is submitted with the values already on it, so no particular input is responsible.
The same request bodies worked on the 07:29 build an hour and a half earlier: tax was enabled at 20% and the timezone moved between `Asia/Beirut` and `Pacific/Midway` without trouble. The form's fields are unchanged between the two builds, so this is a server-side regression rather than a changed contract. Everything else still posts normally, which places the fault in this one controller rather than in sessions, CSRF or the database.
Steps to Reproduce: 1. Open Settings. Note the business name, currency, tax rate and timezone already shown. 2. Press save on the tax section without changing anything. The response is HTTP 500. 3. Repeat for timezone, company and brand — each returns HTTP 500. 4. Reload Settings. Nothing has changed; `tax_rate` is still `0` and `tax_enabled` still unchecked. 5. For contrast, create a contact, an item and an invoice — `POST /contacts`, `POST /items` and `POST /invoices` all return HTTP 200 and save correctly.
Resolution: Not reproducible on the current build — this is already fixed.
All four sections of POST /settings/company were exercised against a real signed-in session, each with the values already on the form, as described in the report:
tax -> HTTP 200 timezone -> HTTP 200 company -> HTTP 200 brand -> HTTP 200
Values round-trip: setting tax to 20% and back to off both persisted and read back correctly on a reload, and saving one section left the others untouched (the business name survived a currency save), which is what SettingsController::SECTIONS exists to guarantee.
A SEPARATE 500-ADJACENT BUG ON THE SAME SCREEN WAS FOUND AND FIXED The second-currency panel — the FX rate — posted to `/settings`, and there is no POST route for that path, only GET. Pressing Save on it answered “Page not found” and lost the pair. Every other Save on the page posts to `/settings/company`; only that one URL was wrong. It now does too, and its `section=currency` marker was already handled by the controller, so nothing else needed to change. Reported separately by the product owner from the screen itself.
Activity / Notes
- 2026-08-11T10:39:56+01:00 - Claude: Not reproducible on the current build — this is already fixed.
All four sections of POST /settings/company were exercised against a real signed-in session, each with the values already on the form, as described in the report:
tax -> HTTP 200 timezone -> HTTP 200 company -> HTTP 200 brand -> HTTP 200
Values round-trip: setting tax to 20% and back to off both persisted and read back correctly on a reload, and saving one section left the others untouched (the business name survived a currency save), which is what SettingsController::SECTIONS exists to guarantee.
A SEPARATE 500-ADJACENT BUG ON THE SAME SCREEN WAS FOUND AND FIXED The second-currency panel — the FX rate — posted to `/settings`, and there is no POST route for that path, only GET. Pressing Save on it answered “Page not found” and lost the pair. Every other Save on the page posts to `/settings/company`; only that one URL was wrong. It now does too, and its `section=currency` marker was already handled by the controller, so nothing else needed to change. Reported separately by the product owner from the screen itself.
Full History
| Date | User | Field | Change |
|---|---|---|---|
| 2026-08-11T10:05:32+01:00 | Nour aboulhosn | issue-new | New Issue |
| 2026-08-11T10:39:52+01:00 | Claude | Assigned To | ⇒ Claudine |
| 2026-08-11T10:39:55+01:00 | Claude | tag-added | Tag Attached: done-by-claude |
| 2026-08-11T10:39:57+01:00 | Claude | note-added | Note Added: 0000164 |
| 2026-08-11T10:39:59+01:00 | Claude | Status | new ⇒ resolved |
Synced automatically from MantisBT issue #206.
