wiki:manara:bugs:notifications_still_not_working_on_live
Differences
This shows you the differences between two versions of the page.
| wiki:manara:bugs:notifications_still_not_working_on_live [2026/07/29 07:49] – Auto-synced from MantisBT mantisbot | wiki:manara:bugs:notifications_still_not_working_on_live [2026/08/03 07:34] (current) – Removed: not a current major-bug page mantisbot | ||
|---|---|---|---|
| Line 1: | Line 1: | ||
| - | ====== notifications still not working on live (Resolved) ====== | ||
| - | |||
| - | **Reported by:** Khaled Tarabay on 2026-07-29T07: | ||
| - | **Assigned to:** Claude\\ | ||
| - | **Resolved by:** Claude on 2026-07-29T07: | ||
| - | **Priority: | ||
| - | **Severity: | ||
| - | **Reproducibility: | ||
| - | **Category: | ||
| - | |||
| - | **Description: | ||
| - | still when creating a task or a maintenance job or assigning any kind of action to an employee the notifications tab still doesn' | ||
| - | |||
| - | **Resolution: | ||
| - | FIXED + verified end-to-end. Two things were wrong, plus the most likely LIVE cause. | ||
| - | |||
| - | === What I found === | ||
| - | 1) Notifications were ONLY raised on TASK assignment. Assigning a MAINTENANCE job or an INSTALLATION to an employee raised NOTHING (no notifyEmployee call existed in either controller) — yet the ticket names maintenance explicitly. Real gap. | ||
| - | 2) The task page's " | ||
| - | |||
| - | === What I fixed (all in app/ | ||
| - | - TaskController.php (assignTo): removed the self-skip — every assignment notifies the assignee now, matching store()/ | ||
| - | - MaintenanceController.php: | ||
| - | - InstallationController.php: | ||
| - | |||
| - | === Verified it ACTUALLY works (real HTTP, signed-in session, against the DB AND the rendered UI, all test rows cleaned up) === | ||
| - | - Create a task assigned to a technician -> that technician gets an in-app notification (entity=task). | ||
| - | - Assign a task to YOURSELF via the Assign button -> YOU now get one (the #2 fix). | ||
| - | - Create a maintenance job assigned to a technician -> notification (entity=maintenance). | ||
| - | - Create an installation assigned to a technician -> notification (entity=installation). | ||
| - | - The topbar BELL renders the unread badge + lists the item, and the / | ||
| - | - Full PHPUnit suite green (29 tests / 859 assertions). All three controllers php -l clean. | ||
| - | |||
| - | === The most likely reason it "still doesn' | ||
| - | The whole notification system is deliberately BEST-EFFORT: | ||
| - | |||
| - | ACTION on prod: | ||
| - | 1. Open / | ||
| - | 2. Upload this task's 3 changed controllers (TaskController, | ||
| - | 3. Confirm the notification feature' | ||
| - | |||
| - | If it still shows nothing after step 1, grab one server error-log line from a task assignment — notifyEmployee logs the exact reason (" | ||
| - | |||
| - | ===== Activity / Notes ===== | ||
| - | |||
| - | * **2026-07-29T07: | ||
| - | |||
| - | === What I found === | ||
| - | 1) Notifications were ONLY raised on TASK assignment. Assigning a MAINTENANCE job or an INSTALLATION to an employee raised NOTHING (no notifyEmployee call existed in either controller) — yet the ticket names maintenance explicitly. Real gap. | ||
| - | 2) The task page's " | ||
| - | |||
| - | === What I fixed (all in app/ | ||
| - | - TaskController.php (assignTo): removed the self-skip — every assignment notifies the assignee now, matching store()/ | ||
| - | - MaintenanceController.php: | ||
| - | - InstallationController.php: | ||
| - | |||
| - | === Verified it ACTUALLY works (real HTTP, signed-in session, against the DB AND the rendered UI, all test rows cleaned up) === | ||
| - | - Create a task assigned to a technician -> that technician gets an in-app notification (entity=task). | ||
| - | - Assign a task to YOURSELF via the Assign button -> YOU now get one (the #2 fix). | ||
| - | - Create a maintenance job assigned to a technician -> notification (entity=maintenance). | ||
| - | - Create an installation assigned to a technician -> notification (entity=installation). | ||
| - | - The topbar BELL renders the unread badge + lists the item, and the / | ||
| - | - Full PHPUnit suite green (29 tests / 859 assertions). All three controllers php -l clean. | ||
| - | |||
| - | === The most likely reason it "still doesn' | ||
| - | The whole notification system is deliberately BEST-EFFORT: | ||
| - | |||
| - | ACTION on prod: | ||
| - | 1. Open / | ||
| - | 2. Upload this task's 3 changed controllers (TaskController, | ||
| - | 3. Confirm the notification feature' | ||
| - | |||
| - | If it still shows nothing after step 1, grab one server error-log line from a task assignment — notifyEmployee logs the exact reason (" | ||
| - | |||
| - | ===== Full History ===== | ||
| - | |||
| - | ^ Date Modified ^ Username ^ Field ^ Change ^ | ||
| - | | 2026-07-29T07: | ||
| - | | 2026-07-29T07: | ||
| - | | 2026-07-29T07: | ||
| - | | 2026-07-29T07: | ||
| - | | 2026-07-29T07: | ||
| - | |||
| - | ---- | ||
| - | Synced automatically from MantisBT issue #137. | ||
wiki/manara/bugs/notifications_still_not_working_on_live.1785307763.txt.gz · Last modified: by mantisbot
